feat: add separator, line numbers and view toggle#41
Open
shatrughantwt wants to merge 2 commits intomasterfrom
Open
feat: add separator, line numbers and view toggle#41shatrughantwt wants to merge 2 commits intomasterfrom
shatrughantwt wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: shatrughan mishra <shatrughanm485@gmail.com>
bakayu
reviewed
Feb 19, 2026
Member
There was a problem hiding this comment.
feedback from QA:
- The line numbers are too close to the actual text, there should be a gap
- When a line becomes too long (check the screenshot attached) it seems to be wrapping around and breaking the vertical divider
- The color of the divider does not match the color of the panel borders
- You have to press
ctrl+dtwice while in split diff view mode to change to unified currently, it should only take one click, probably some issue with how the update function was modified - Also the colors of text in split diff view and unified diff view are not consistent
Contributor
Author
okayy. I'll fix it |
Signed-off-by: shatrughan mishra <shatrughanm485@gmail.com>
Contributor
Author
|
help me with the vertical divider issue |
Member
I'll get to this by this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up PR to further enhance the diff viewer with improved layout and usability.
Changes
splitViewThresholdResult
Cleaner split layout, improved readability and better overall user experience.